[Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

David C. Partridge
Even with the corrected source I just submitted, mondoarchive appears to be
writing buffers of size 32768 (in the case in point I request a tape buffer
of 65536).

amonra@Charon:~$ ps -ef | grep [m]ondo
root      4011 20411  0 19:07 pts/2    00:00:00 sh -c gzip -c1 >
/tmp/mondo.tmp.RkpOWo/acl_list.200.gz
root      9440 20411  0 18:44 pts/2    00:00:00 sh -c buffer -m 32m -p75 -B
-s32768 -o /dev/st0l 2>> /var/log/mondoarchive.log   <--------------- This
line
root     20411 20427  9 18:30 pts/2    00:03:23 ./mondoarchive

Dave




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

David C. Partridge
Yuk!

Running a (slightly modfied) version of that code:

       
mr_asprintf(sz_size,"%ld",bkpinfo->internal_tape_block_size);
                tmp = mr_popup_and_get_string("Tape block size?", "What is
the block size of your tape streamer?", sz_size);
                if (tmp == NULL) {
                        log_to_screen("User has chosen not to backup the
PC");
                        finish(1);
                }
                bkpinfo->internal_tape_block_size = atol(tmp);
                mr_free(sz_size); sz_size=NULL; mr_free(tmp); tmp=NULL;
               
under gdb, shows that the compiler has chosen to optimise out the setting of
bkpinfo->internal_tape_block_size .

It also appears to have optimised out the return value from
mr_popup_and_get_string so the char* value returned bears no relation to the
value that variable entry_value had at line 775 of newt-specfic.c.

Arrgghh!

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

Dave

-----Original Message-----
From: David C. Partridge [mailto:[hidden email]]
Sent: 12 December 2016 19:16
To: 'Mondo mailing list'
Subject: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Even with the corrected source I just submitted, mondoarchive appears to be
writing buffers of size 32768 (in the case in point I request a tape buffer
of 65536).

amonra@Charon:~$ ps -ef | grep [m]ondo
root      4011 20411  0 19:07 pts/2    00:00:00 sh -c gzip -c1 >
/tmp/mondo.tmp.RkpOWo/acl_list.200.gz
root      9440 20411  0 18:44 pts/2    00:00:00 sh -c buffer -m 32m -p75 -B
-s32768 -o /dev/st0l 2>> /var/log/mondoarchive.log   <--------------- This
line
root     20411 20427  9 18:30 pts/2    00:03:23 ./mondoarchive

Dave




----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

David C. Partridge
Digging further it would appear that this relates somewhat to a problem in
mr_popup_and_get_string() in newt-specific.c

Running under the debugger, I can see that typed value pointed to by
entry_value at line 770.  It seems the call to newtFormDestroy wipes out the
value I typed in.

I think this needs some looking at by the developers.  Please!!!!

Dave
-----Original Message-----
From: David C. Partridge [mailto:[hidden email]]
Sent: 14 December 2016 13:36
To: 'Mondo mailing list'
Subject: Re: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Yuk!

Running a (slightly modfied) version of that code:

       
mr_asprintf(sz_size,"%ld",bkpinfo->internal_tape_block_size);
                tmp = mr_popup_and_get_string("Tape block size?", "What is
the block size of your tape streamer?", sz_size);
                if (tmp == NULL) {
                        log_to_screen("User has chosen not to backup the
PC");
                        finish(1);
                }
                bkpinfo->internal_tape_block_size = atol(tmp);
                mr_free(sz_size); sz_size=NULL; mr_free(tmp); tmp=NULL;
               
under gdb, shows that the compiler has chosen to optimise out the setting of
bkpinfo->internal_tape_block_size .

It also appears to have optimised out the return value from
mr_popup_and_get_string so the char* value returned bears no relation to the
value that variable entry_value had at line 775 of newt-specfic.c.

Arrgghh!

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

Dave

-----Original Message-----
From: David C. Partridge [mailto:[hidden email]]
Sent: 12 December 2016 19:16
To: 'Mondo mailing list'
Subject: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Even with the corrected source I just submitted, mondoarchive appears to be
writing buffers of size 32768 (in the case in point I request a tape buffer
of 65536).

amonra@Charon:~$ ps -ef | grep [m]ondo
root      4011 20411  0 19:07 pts/2    00:00:00 sh -c gzip -c1 >
/tmp/mondo.tmp.RkpOWo/acl_list.200.gz
root      9440 20411  0 18:44 pts/2    00:00:00 sh -c buffer -m 32m -p75 -B
-s32768 -o /dev/st0l 2>> /var/log/mondoarchive.log   <--------------- This
line
root     20411 20427  9 18:30 pts/2    00:03:23 ./mondoarchive

Dave




----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

David C. Partridge
In reply to this post by David C. Partridge
Oh my good grief - mr_popup_and_get_string can never have worked.  

The documentation for newtEntry says:

The resultPtr must be the address of a char *. Until the entry box is
destroyed by newtFormDestroy(), that char * will point to the current value
of the entry box.

The onus is on mr_popup_and_get_string to  malloc an area to hold the
returned string and to copy the data to that malloced area.

Let me see if I can work up a fix.

Dave
-----Original Message-----
From: David C. Partridge [mailto:[hidden email]]
Sent: 14 December 2016 13:36
To: 'Mondo mailing list'
Subject: Re: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Yuk!

Running a (slightly modfied) version of that code:

       
mr_asprintf(sz_size,"%ld",bkpinfo->internal_tape_block_size);
                tmp = mr_popup_and_get_string("Tape block size?", "What is
the block size of your tape streamer?", sz_size);
                if (tmp == NULL) {
                        log_to_screen("User has chosen not to backup the
PC");
                        finish(1);
                }
                bkpinfo->internal_tape_block_size = atol(tmp);
                mr_free(sz_size); sz_size=NULL; mr_free(tmp); tmp=NULL;
               
under gdb, shows that the compiler has chosen to optimise out the setting of
bkpinfo->internal_tape_block_size .

It also appears to have optimised out the return value from
mr_popup_and_get_string so the char* value returned bears no relation to the
value that variable entry_value had at line 775 of newt-specfic.c.

Arrgghh!

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

Dave

-----Original Message-----
From: David C. Partridge [mailto:[hidden email]]
Sent: 12 December 2016 19:16
To: 'Mondo mailing list'
Subject: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Even with the corrected source I just submitted, mondoarchive appears to be
writing buffers of size 32768 (in the case in point I request a tape buffer
of 65536).

amonra@Charon:~$ ps -ef | grep [m]ondo
root      4011 20411  0 19:07 pts/2    00:00:00 sh -c gzip -c1 >
/tmp/mondo.tmp.RkpOWo/acl_list.200.gz
root      9440 20411  0 18:44 pts/2    00:00:00 sh -c buffer -m 32m -p75 -B
-s32768 -o /dev/st0l 2>> /var/log/mondoarchive.log   <--------------- This
line
root     20411 20427  9 18:30 pts/2    00:03:23 ./mondoarchive

Dave




----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

Bruno Cornec-4
David C. Partridge said on Wed, Dec 14, 2016 at 02:50:46PM +0000:
>Oh my good grief - mr_popup_and_get_string can never have worked.

What is the best way for you to test a new version ?
Packages for 16.04 are not yet available (due to busybox issues).

Would a tar ball be ok ?

I hopefully have fixed the issues you reported, and would like you to test the new content.
Best regards,
Bruno.
--
Open Source Profession, WW Linux Community Lead     http://www.hpintelco.net
HPE EMEA EG FLOSS Technology Strategist http://www.hpe.com/engage/opensource
FLOSS projects:    http://mondorescue.org         http://project-builder.org
Musique ancienne?   http://www.musique-ancienne.org  http://www.medieval.org

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Mondo-devel] Mondoarchive appears to ignore requested tape blocksize

David C. Partridge
Yes I can eat a tar file.

Dave

-----Original Message-----
From: Bruno Cornec [mailto:[hidden email]]
Sent: 20 December 2016 10:55
To: Mondo mailing list
Subject: Re: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

David C. Partridge said on Wed, Dec 14, 2016 at 02:50:46PM +0000:
>Oh my good grief - mr_popup_and_get_string can never have worked.

What is the best way for you to test a new version ?
Packages for 16.04 are not yet available (due to busybox issues).

Would a tar ball be ok ?

I hopefully have fixed the issues you reported, and would like you to test
the new content.
Best regards,
Bruno.
--
Open Source Profession, WW Linux Community Lead     http://www.hpintelco.net
HPE EMEA EG FLOSS Technology Strategist http://www.hpe.com/engage/opensource
FLOSS projects:    http://mondorescue.org         http://project-builder.org
Musique ancienne?   http://www.musique-ancienne.org  http://www.medieval.org

----------------------------------------------------------------------------
--
Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon
Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
Mondo-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mondo-devel